-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(mui): upgrade @mui/x-data-grid from v7 to v8 #7208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JuicyBenjamin
wants to merge
10
commits into
refinedev:main
Choose a base branch
from
JuicyBenjamin:feat/upgrade-mui-x-data-grid-v8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(mui): upgrade @mui/x-data-grid from v7 to v8 #7208
JuicyBenjamin
wants to merge
10
commits into
refinedev:main
from
JuicyBenjamin:feat/upgrade-mui-x-data-grid-v8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5a0d18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5e504da to
79f10bd
Compare
- Updated @mui/x-data-grid peer dependency from ^7.23.5 to ^8.24.0 - Added vitest config fix for MUI X v8 ESM imports - Updated all examples to use @mui/x-data-grid v8 - All existing tests pass with the upgrade BREAKING CHANGE: This is a major version bump as MUI X v8 includes breaking changes. See https://mui.com/x/migration/migration-data-grid-v7/
79f10bd to
b42b358
Compare
- Remove unnecessary @ts-expect-error directives - Update GridRowSelectionModel usage to v8 API (Set-based) - Upgrade @mui/x-data-grid-pro to v8
52809dd to
628a665
Compare
…ility MUI X v8 exports CSS files that Node.js cannot parse. Remix without Vite runs on Node.js, causing 'SyntaxError: Unexpected token' errors. - Added regex to ignore with-remix-material-ui and with-remix-mui from CI - Added README warnings to affected examples - Examples can be re-enabled once they migrate to Remix + Vite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This is a major version bump as MUI X v8 includes breaking changes. See https://mui.com/x/migration/migration-data-grid-v7/
MUI X v8 exports CSS files that are imported at runtime. Remix without Vite runs on Node.js, which cannot parse CSS imports and throws:
Affected examples:
with-remix-material-uiwith-remix-muiThese examples have been disabled from CI testing until they migrate to Remix + Vite. A warning has been added to their READMEs.
Workaround: Migrate to Remix + Vite for full MUI X v8 support.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Using @mui/x-data-grid v7
What is the new behavior?
Using @mui/x-data-grid v8 with proper CSS import handling
Notes for reviewers
MUI X v8 now exports CSS files directly. This works fine with modern bundlers (Vite, webpack, etc.) but breaks Remix examples that don't use Vite because Node.js cannot parse CSS imports at runtime.