Skip to content

fix: extend BaseKey to support number[] for UUID types#7404

Open
Xenon010101 wants to merge 1 commit intorefinedev:mainfrom
Xenon010101:fix/basekey-uuid-support
Open

fix: extend BaseKey to support number[] for UUID types#7404
Xenon010101 wants to merge 1 commit intorefinedev:mainfrom
Xenon010101:fix/basekey-uuid-support

Conversation

@Xenon010101
Copy link
Copy Markdown

@Xenon010101 Xenon010101 commented Apr 25, 2026

  • Extended BaseKey type from 'string | number' to 'string | number | number[]'
  • Allows OpenAPI-generated types using number[] for UUIDs to work without type casting
  • Added comprehensive tests for all BaseKey variants
  • Resolves [BUG] BaseKey needs to support UUID #7403

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes (issue)

Notes for reviewers

- Extended BaseKey type from 'string | number' to 'string | number | number[]'
- Allows OpenAPI-generated types using number[] for UUIDs to work without type casting
- Added comprehensive tests for all BaseKey variants
- Resolves refinedev#7403
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 25, 2026

⚠️ No Changeset found

Latest commit: 55c7391

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pcfreak30
Copy link
Copy Markdown
Contributor

Thank you but https://github.com/Xenon010101/refine/blob/55c739158b98829fe6fad332ccb5aaac115585e1/packages/core/src/__tests__/basekey.test.ts this test file is honestly kind of useless as you aren't testing the types nor can you really. I would delete this, amend, and force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] BaseKey needs to support UUID

2 participants