feat(core): add options.logout.confirm for logout confirmation dialog#7405
Open
Amaanghazi22 wants to merge 2 commits intorefinedev:mainfrom
Open
feat(core): add options.logout.confirm for logout confirmation dialog#7405Amaanghazi22 wants to merge 2 commits intorefinedev:mainfrom
Amaanghazi22 wants to merge 2 commits intorefinedev:mainfrom
Conversation
Adds a new `logout.confirm` option to Refine options that shows a confirmation dialog before executing logout. Defaults to false to preserve existing behavior. - core: add `logout.confirm` to IRefineOptions type and defaults - antd: ThemedSider shows Modal.confirm when logout.confirm is true - mui: ThemedSider shows window.confirm when logout.confirm is true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Related issue: N/A (UX improvement proposal)
What is the current behavior?
Clicking logout in the sider or header immediately logs the user out with no confirmation. Users can accidentally log out while navigating.
What is the new behavior?
A new
logout.confirmoption can be set in<Refine options={{ logout: { confirm: true } }}>. When enabled, a confirmation dialog is shown before logout executes. Defaults to false — no breaking change.Notes for reviewers
This is a UX improvement. The option defaults to false so existing behavior is fully preserved.
Happy to add tests, docs, and a changeset if maintainers want to move forward.