WIP: Feature/mobility #6
Conversation
config/routes.rb
Outdated
| end | ||
|
|
||
| end | ||
| end |
There was a problem hiding this comment.
Layout/TrailingBlankLines: Final newline missing.
| @@ -1,4 +1,4 @@ | |||
| Refinery::Core::Engine.routes.append do | |||
| Refinery::Core::Engine.routes.draw do | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| before_filter :find_image_slide, :except => [:index, :new] | ||
| before_action :find_image_slideshow | ||
| before_action :find_image_slides, only: :index | ||
| before_action :find_image_slide, :except => [:index, :new] |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/SymbolArray: Use %i or %I for an array of symbols.
Gemfile
Outdated
| end | ||
|
|
||
| # TODO: remove refinerycms-i18n and mobility from this Gemfile before merging this PR | ||
| gem 'refinerycms-i18n', git: "https://github.com/refinery/refinerycms-i18n", branch: 'feature/mobility' |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [103/80]
Gemfile
Outdated
| end | ||
| end | ||
|
|
||
| # TODO: remove refinerycms-i18n and mobility from this Gemfile before merging this PR |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [85/80]
| class CreateImageSlidesTranslations < ActiveRecord::Migration[5.1] | ||
| def change | ||
| create_table :refinery_image_slide_translations do |t| | ||
|
|
There was a problem hiding this comment.
Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
| :migrate_data => true | ||
| }) | ||
| end | ||
| class CreateImageSlidesTranslations < ActiveRecord::Migration[5.1] |
There was a problem hiding this comment.
Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| @@ -1,4 +1,4 @@ | |||
| class AddHeightAndWidthToImageSlideshows < ActiveRecord::Migration | |||
| class AddHeightAndWidthToImageSlideshows < ActiveRecord::Migration[5.1] | |||
There was a problem hiding this comment.
Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| @@ -1,4 +1,4 @@ | |||
| class AddLinkUrlToImageSlides < ActiveRecord::Migration | |||
| class AddLinkUrlToImageSlides < ActiveRecord::Migration[5.1] | |||
There was a problem hiding this comment.
Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| @@ -1,4 +1,4 @@ | |||
| class AddJsConfigToImageSlideshows < ActiveRecord::Migration | |||
| class AddJsConfigToImageSlideshows < ActiveRecord::Migration[5.1] | |||
There was a problem hiding this comment.
Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Remove deprecated "quiet_assets" gem
Bugfix dependency resolution
|
|
||
| def image_slideshow_params | ||
| params.require(:image_slideshow).permit( | ||
| :active, |
There was a problem hiding this comment.
by convention we use draft logic instead of active logic
| <% end %> | ||
| </span> | ||
|
|
||
| <%= content_tag :span, class: "#{image_slide.active? ? :success_icon : :failure_icon} less-important" do %> |
There was a problem hiding this comment.
We have label to handle draft display: https://github.com/refinery/refinerycms/blob/88f3eee61914d548dce5e7c1d1f8d3a57a0c9ece/pages/app/helpers/refinery/admin/pages_helper.rb#L51-L53
QA Feature/mobility
3 participants
Uh oh!
There was an error while loading. Please reload this page.