Skip to content

Conversation

@lefarcen
Copy link
Contributor

@lefarcen lefarcen commented Dec 18, 2025

Summary

Remove explicit accept prop and MIME type mapping from FileInput component in mixed-text-editor.

Changes:

  • Removed getAcceptTypes function that mapped resourceTypes to MIME types
  • Removed accept prop from FileInput, allowing all file types to be uploaded

Impact Areas

  • Workflow Variables (File Upload)

Checklist

  • I understand that this PR may be closed in case there was no previous discussion or issues.
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

… prop and MIME type mapping from `FileInput` component.
@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Walkthrough

Removed MIME-accept type filtering from resource variable file uploads by eliminating the getAcceptTypes helper function and removing the accept prop passed to the FileInput component. File uploads for resource variables now proceed without explicit MIME-type restrictions.

Changes

Cohort / File(s) Change Summary
File Input Filtering Removal
packages/ai-workspace-common/src/components/workflow-app/mixed-text-editor/mixed-text-editor.tsx
Deleted getAcceptTypes helper and its usage; removed accept prop from FileInput component for resource-type variables, eliminating runtime MIME-type filtering

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Single file modification with straightforward removal of MIME-type filtering logic
  • Helper function deletion is clear and localized
  • No new logic introduced; primarily code reduction

Poem

🐰 A simpler path for files to flow,
No MIME-type walls to block or slow,
The helper's gone, the filters too,
FileInput runs with freedom new!
Less complexity, more we know.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing file type restrictions from FileInput in the mixed-text-editor component by eliminating the accept prop and MIME-type filtering.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/mashu/file-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lefarcen lefarcen changed the title docs: Add evaluation automation proposal and remove explicit accept fix: Remove file type restrictions from FileInput in mixed-text-editor Dec 18, 2025
@mrcfps mrcfps merged commit 9b22c17 into main Dec 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants