Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Safari ClientHello parrot preset and makes it the default Safari “Auto” fingerprint, updating the library’s Safari TLS handshake emulation to a newer profile.
Changes:
- Add
HelloSafari_26_3ClientHelloIDand map it to a newClientHelloSpecinutlsIdToSpec. - Update
HelloSafari_Autoto point toHelloSafari_26_3instead ofHelloSafari_16_0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
u_parrots.go |
Introduces the HelloSafari_26_3 ClientHelloSpec (ciphers/extensions/curves/keyshares) in the parrot switch. |
u_common.go |
Registers the new HelloSafari_26_3 ID and updates HelloSafari_Auto to use it by default. |
Comments suppressed due to low confidence (2)
u_parrots.go:2246
- A new
HelloSafari_26_3fingerprint is introduced here, but there isn't a corresponding test ensuring the preset can be converted viaUTLSIdToSpecand successfully applied viaApplyPreset(and that the resulting extension list/keyshares match expectations). Adding a small unit test would help prevent future regressions in this fingerprint.
case HelloSafari_26_3:
return ClientHelloSpec{
TLSVersMin: VersionTLS12,
TLSVersMax: VersionTLS13,
CipherSuites: []uint16{
u_common.go:661
HelloSafari_Autonow points toHelloSafari_26_3, which changes the default Safari parrot behavior for any callers using the auto preset (e.g., drops TLS 1.0/1.1 support and changes the extension set). If this is intended, it would be good to treat it as an API/behavior change (e.g., mention in release notes / CHANGELOG); otherwise consider keepingHelloSafari_Autoon the previous preset for backward compatibility and letting callers opt intoHelloSafari_26_3explicitly.
HelloSafari_Auto = HelloSafari_26_3
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.