Add ConnectionMetrics to expose session ticket/PSK usage#387
Open
thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
Open
Add ConnectionMetrics to expose session ticket/PSK usage#387thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
thesinakamali wants to merge 1 commit intorefraction-networking:masterfrom
Conversation
Add a ConnectionMetrics struct and Conn.ConnectionMetrics() method that allows consumers to determine whether the client sent a TLS 1.2 session ticket or a TLS 1.3 PSK in the ClientHello. This is useful for metrics and diagnostics around session resumption behavior. Changes: - Add ConnectionMetrics struct in common.go - Add clientSentTicket field to Conn in conn.go - Add ConnectionMetrics() method on Conn in conn.go - Set clientSentTicket after writeHandshakeRecord in u_handshake_client.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ConnectionMetrics struct and Conn.ConnectionMetrics() method that allows consumers to determine whether the client sent a TLS 1.2 session ticket or a TLS 1.3 PSK in the ClientHello. This is useful for metrics and diagnostics around session resumption behavior.
Changes: