Fix URL encoding bug in Defender adapter OData filter query #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manual percent-encoding of query parameters caused malformed URLs where the datetime value included query parameter syntax (e.g., '2025-11-17T10:27:18.440439Z?$filter=createdDateTime'). This resulted in Microsoft API BadRequest errors. Replace manual string concatenation with proper net/url package usage to ensure correct URL construction and parameter escaping. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
net/urlpackage usage for correct OData filter query parameters2025-11-17T10:27:18.440439Z?$filter=createdDateTime)Test plan
https://graph.microsoft.com/v1.0/security/alerts_v2?$filter=createdDateTime+ge+<timestamp>🤖 Generated with Claude Code