Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-222 web3 confirmation email #2590

Merged
merged 6 commits into from
Feb 11, 2025
Merged

Conversation

blushi
Copy link
Member

@blushi blushi commented Jan 30, 2025

Description

Part of https://regennetwork.atlassian.net/browse/APP-222

Needs https://github.com/regen-network/regen-server/pull/519 before it can be tested


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Log in with a web3 account with no email address.
When buying credits, provide some email address:

  • (Needs https://github.com/regen-network/regen-server/pull/522) that is already used, you should see a popup telling you to update the email
  • that isn't used by another account, after clicking "purchase" on the last step, you should get an email to confirm your email address. Click the link in the email, you should see your account settings page with some success banner et the email you provided should appear as "login email".

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@blushi blushi requested a review from r41ph January 30, 2025 13:41
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 39bbbe7
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/67aaf6277c32840008a12a55
😎 Deploy Preview https://deploy-preview-2590--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 39bbbe7
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67aaf6277bc6eb00081581b7
😎 Deploy Preview https://deploy-preview-2590--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Jan 30, 2025

@erikalogie @S4mmyb see testing instructions

@erikalogie
Copy link
Collaborator

@blushi is the confirmation time 5 minutes only on dev? I thought we decided on 24 hours...

@blushi
Copy link
Member Author

blushi commented Jan 31, 2025

@blushi is the confirmation time 5 minutes only on dev? I thought we decided on 24 hours...

No I set it to 24 hours, why?
5 minutes is for the 6 digit code for logging in.

@erikalogie
Copy link
Collaborator

@blushi is the confirmation time 5 minutes only on dev? I thought we decided on 24 hours...

No I set it to 24 hours, why? 5 minutes is for the 6 digit code for logging in.

It says 5 minutes on the email:
Screenshot 2025-01-31 at 9 00 14 AM

@blushi
Copy link
Member Author

blushi commented Feb 3, 2025

@erikalogie ok this was just some environment variable issue for displaying in the email, it should be fixed now

@erikalogie
Copy link
Collaborator

LGTM

@blushi blushi force-pushed the feat-APP-222-web3-confirm-email branch from a108ee8 to e8f9561 Compare February 4, 2025 11:18
@S4mmyb
Copy link
Member

S4mmyb commented Feb 5, 2025

@blushi , I'm not getting the pop-up telling me the email is linked with another account. Does regen-server #522 need to get merged for us to see this popup?

@blushi
Copy link
Member Author

blushi commented Feb 6, 2025

@blushi , I'm not getting the pop-up telling me the email is linked with another account. Does regen-server #522 need to get merged for us to see this popup?

yes as described in the description, it needs https://github.com/regen-network/regen-server/pull/522 to be merged before

@blushi
Copy link
Member Author

blushi commented Feb 10, 2025

@blushi , I'm not getting the pop-up telling me the email is linked with another account. Does regen-server #522 need to get merged for us to see this popup?

yes as described in the description, it needs regen-network/regen-server#522 to be merged before

@S4mmyb the server PR is now merged so this can be tested

@S4mmyb
Copy link
Member

S4mmyb commented Feb 11, 2025

LGTM

@blushi blushi force-pushed the feat-APP-222-web3-confirm-email branch from 3198f92 to 39bbbe7 Compare February 11, 2025 07:03
@blushi blushi enabled auto-merge (squash) February 11, 2025 07:03
@blushi blushi merged commit 04307c0 into dev Feb 11, 2025
12 of 14 checks passed
@blushi blushi deleted the feat-APP-222-web3-confirm-email branch February 11, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants