fix: APP-571 disable credit card option when available fiat credits are below $0.5 #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
blushi
commented
Feb 6, 2025
Comment on lines
+55
to
+59
| value >= MIN_USD_CURRENCY_AMOUNT, | ||
| { | ||
| message: `${i18n._(MIN_USD_AMOUNT)} 0.5`, | ||
| message: `${i18n._( | ||
| MIN_USD_AMOUNT, | ||
| )} ${MIN_USD_CURRENCY_AMOUNT.toLocaleString()}`, |
There was a problem hiding this comment.
unrelated but just thought I would use our const instead of 0.5 directly
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@erikalogie @S4mmyb see testing instructions |
|
This is working as expected |
r41ph
approved these changes
Feb 6, 2025
web-marketplace/src/lib/normalizers/projects/normalizeProjectsWithMetadata.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: https://regennetwork.atlassian.net/browse/APP-571
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
This can be tested on https://deploy-preview-2592--regen-marketplace.netlify.app/project/C01-010
As you can on Sanity, this project has some fiat sell orders set up: https://regen.sanity.studio/staging/structure/shared;projects;english;c9ae90a7-d3d4-4ffa-b1da-baf573b783f6
with corresponding quantities: http://redwood.regen.network:1317/regen/ecocredit/marketplace/v1/sell-orders/413 has 1 and http://redwood.regen.network:1317/regen/ecocredit/marketplace/v1/sell-orders/414 has 2 credits
but if buying all fiat credits, it would result in 0.11 + 0.12 = 0.3 which is lower than $0.5 (min accepted by Stripe) so:
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...