Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-447 remove dropdown when only one crypto currency available #2593

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Feb 6, 2025

Description

https://regennetwork.atlassian.net/browse/APP-447

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Verify that projects with a single crypto currency available should not have a dropdown in the currency field while projects with multiple options should have a dropdown:

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit c9a512c
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/67ab3b3f7fa837000859c44c
😎 Deploy Preview https://deploy-preview-2593--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit c9a512c
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67ab3b3f1e717e00088dec56
😎 Deploy Preview https://deploy-preview-2593--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph
Copy link
Contributor Author

r41ph commented Feb 6, 2025

@erikalogie @S4mmyb see testing instructions

@r41ph r41ph requested a review from blushi February 6, 2025 14:02
@erikalogie
Copy link
Collaborator

@r41ph this looks good, only question I have is whether on production do we have icons for all the different currencies?

Screenshot 2025-02-06 at 10 56 22 AM

@r41ph
Copy link
Contributor Author

r41ph commented Feb 6, 2025

@erikalogie I believe these are the ones we currently have implemented + the regen token one:

image

Do we have a list of the currencies we need, and their icons?

@blushi
Copy link
Member

blushi commented Feb 6, 2025

Do we have a list of the currencies we need, and their icons?

For production: http://mainnet.regen.network:1317/regen/ecocredit/marketplace/v1/allowed-denoms
But this can change through a governance proposal

@erikalogie
Copy link
Collaborator

axlUSDC
USDC grv

Here are these, not sure if they will be used but maybe better to have so it does not appear blank next to that currency.

@r41ph
Copy link
Contributor Author

r41ph commented Feb 6, 2025

OK, in http://redwood.regen.network:1317/regen/ecocredit/marketplace/v1/allowed-denoms we have USDC.axl and aUSDC but they seem to use the same icon.. is that right?

Is GravUsdc the same as USDC.grv and AxlUsdc the same as USDC.axl?

@erikalogie
Copy link
Collaborator

OK, in http://redwood.regen.network:1317/regen/ecocredit/marketplace/v1/allowed-denoms we have USDC.axl and aUSDC but they seem to use the same icon.. is that right?

Sounds right to me

Is GravUsdc the same as USDC.grv and AxlUsdc the same as USDC.axl?

Yes those are the same

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@S4mmyb
Copy link
Member

S4mmyb commented Feb 11, 2025

Looks good to me, assuming the icons will be fixed on prod

@r41ph r41ph force-pushed the fix-APP-447-remove-dropdown-when-only-one-crypto branch from 8de6c1a to 9417df9 Compare February 11, 2025 09:23
@r41ph r41ph force-pushed the fix-APP-447-remove-dropdown-when-only-one-crypto branch from 9417df9 to c9a512c Compare February 11, 2025 11:57
@r41ph r41ph merged commit 8c5378b into dev Feb 11, 2025
18 checks passed
@r41ph r41ph deleted the fix-APP-447-remove-dropdown-when-only-one-crypto branch February 11, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants