-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: APP-447 remove dropdown when only one crypto currency available #2593
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie @S4mmyb see testing instructions |
@r41ph this looks good, only question I have is whether on production do we have icons for all the different currencies? ![]() |
@erikalogie I believe these are the ones we currently have implemented + the regen token one: Do we have a list of the currencies we need, and their icons? |
For production: http://mainnet.regen.network:1317/regen/ecocredit/marketplace/v1/allowed-denoms |
OK, in http://redwood.regen.network:1317/regen/ecocredit/marketplace/v1/allowed-denoms we have Is |
Sounds right to me
Yes those are the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Looks good to me, assuming the icons will be fixed on prod |
8de6c1a
to
9417df9
Compare
9417df9
to
c9a512c
Compare
Description
https://regennetwork.atlassian.net/browse/APP-447
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...