Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-540 add support for commas in editable input #2598

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Feb 12, 2025

Description

https://regennetwork.atlassian.net/browse/APP-540

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Verify that the decimal and thousands separators reflect the user's location in:
  • Order summary card in the editable input and the prices => buy Credits flow step 2
  • In the credits and currency inputs => buy Credits flow step 1
  • Buy Credits flow success modal
  • My Orders page
  • ... maybe we should standardise this and use the right numbers format based on location all across the marketplace, wdyt?

While working on this I've been changing the browser's language (in Chrome in Settings > Language > Preferred languages) and putting different languages on top makes the numbers format change. I haven't been able to see this settings update work on the buy credits flow step 1, although I think @blushi can see the French local format (commas) in step 1, is that right?

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 70fc523
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/67aca2189fbc7b0008ac702c
😎 Deploy Preview https://deploy-preview-2598--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for terrasos canceled.

Name Link
🔨 Latest commit 70fc523
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67aca218dd54d20008836d5b

@r41ph
Copy link
Contributor Author

r41ph commented Feb 12, 2025

@erikalogie @S4mmyb see testing instructions

@r41ph r41ph requested a review from blushi February 12, 2025 13:37
@erikalogie
Copy link
Collaborator

@r41ph how can I test this, I used my VPN to connect to a place in France but it doesn't seem to work

@r41ph
Copy link
Contributor Author

r41ph commented Feb 13, 2025

@erikalogie I believe is the browser's setting language that is checked for this not the location. The browser is the one handling the numbers formatting (in the cases where they do it, because some browsers/versions just let HTML handle it, which means they don't show commas)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants