Skip to content

remove spurious tag from torchdata#41

Closed
h-vetinari wants to merge 1 commit intoregro:masterfrom
h-vetinari:torchdata
Closed

remove spurious tag from torchdata#41
h-vetinari wants to merge 1 commit intoregro:masterfrom
h-vetinari:torchdata

Conversation

@h-vetinari
Copy link

This tag permanently broke the update bot, even though it has been deleted upstream in the meantime.

image

@h-vetinari
Copy link
Author

The failures here are unrelated.

@h-vetinari h-vetinari requested a review from beckermr February 22, 2025 22:28
Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the bot config options. There is one to set on the feedstock to ignore tags. Please add this there. This pr wont fix things because the bot will just find the tag again.

@h-vetinari
Copy link
Author

This pr wont fix things because the bot will just find the tag again.

The tag has been deleted, as I show in the OP

@beckermr
Copy link
Collaborator

Ahhhh. Even so you need the check the file under the versions folder too then to be sure. The versions here are about attempted version PRs. The source of truth for new versions is the versions directory.

However, if you add the now-deleted tag to the excluded versions in the feedstock anyways, the bot should reset itself here without you having to dig around in the files.

@beckermr
Copy link
Collaborator

To be a bit more clear, the bot enforces that new versions always increase relative to the version it last found. It should bypass this if the version is in the excluded list.

@beckermr
Copy link
Collaborator

It appears that the exclude worked!

Note for this PR to have worked, we'd have to have edited the file in the version directory as well.

@beckermr beckermr closed this Feb 23, 2025
@h-vetinari h-vetinari deleted the torchdata branch February 23, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants