Skip to content

feat(filmstrip): restore keyboard focus parity and add scrollNavigate event#213

Merged
saagude merged 3 commits intomainfrom
pr/filmstrip-arrow-focus
Jun 20, 2025
Merged

feat(filmstrip): restore keyboard focus parity and add scrollNavigate event#213
saagude merged 3 commits intomainfrom
pr/filmstrip-arrow-focus

Conversation

@HeavyMedl
Copy link
Copy Markdown
Collaborator

This PR restores expected keyboard navigation behavior and introduces enhancements to the CdrFilmstrip.vue component for better tracking and developer ergonomics.

  1. Restored feature parity with @rei/recommendations-slider
  • When navigating via keyboard (arrow keys), the filmstrip now shifts focus to the next or previous frame, matching the behavior in the legacy @rei/recommendations-slider implementation.
  1. New scrollNavigate event
  • Introduces a new scrollNavigate event that emits when the user manually scrolls the filmstrip (e.g., via trackpad or scrollbar).
  • The event is not emitted during programmatic scrolls triggered by:
    • Arrow button clicks
    • Keyboard focus navigation
  • Payload includes:
    • event: original scroll event
    • index: the active frame index
    • model: the props of the frame at that index
  1. Vue Styleguidist annotations
  • Added missing annotations to the CdrFilmstripEngine.vue component for improved styleguide integration.

…lNavigate event. Adds more annotation for docgen
@HeavyMedl HeavyMedl self-assigned this May 22, 2025
@HeavyMedl HeavyMedl requested a review from mhewson May 22, 2025 20:40
@saagude saagude merged commit f2c8cc0 into main Jun 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants