feat(filmstrip): restore keyboard focus parity and add scrollNavigate event#213
Merged
feat(filmstrip): restore keyboard focus parity and add scrollNavigate event#213
scrollNavigate event#213Conversation
…lNavigate event. Adds more annotation for docgen
c4rlosviteri
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores expected keyboard navigation behavior and introduces enhancements to the
CdrFilmstrip.vuecomponent for better tracking and developer ergonomics.@rei/recommendations-slider@rei/recommendations-sliderimplementation.scrollNavigateeventscrollNavigateevent that emits when the user manually scrolls the filmstrip (e.g., via trackpad or scrollbar).event: original scroll eventindex: the active frame indexmodel: the props of the frame at that indexCdrFilmstripEngine.vuecomponent for improved styleguide integration.