Skip to content

Add surface scroll#216

Merged
c4rlosviteri merged 2 commits intomainfrom
pr/surface-scroll
Jul 1, 2025
Merged

Add surface scroll#216
c4rlosviteri merged 2 commits intomainfrom
pr/surface-scroll

Conversation

@c4rlosviteri
Copy link
Copy Markdown
Contributor

Overview

This PR introduces a new CdrSurfaceScroll component and refactors the existing CdrFilmstrip component to use this new scrolling implementation.

Changes Made

🆕 New Component

  • Added CdrSurfaceScroll component in src/components/scroll/
    • New Vue component with TypeScript interfaces
    • Comprehensive test suite
    • SCSS styling with modular approach

🔄 Filmstrip Refactor

  • Replaced CdrFilmstripEngine with CdrSurfaceScroll in CdrFilmstrip.vue
    • Updated component imports and usage
    • Maintained all existing props and functionality
    • Updated JSDoc to reflect the new underlying component

🧪 Testing Updates

  • Updated test files to reflect the component changes
    • Modified imports from CdrFilmstripEngine to CdrSurfaceScroll
    • Ensured test coverage for the new implementation

📦 Dependencies

  • Updated radix-vue from ^1.9.16 to ^1.9.17
    • Minor version bump for improved compatibility

🗂️ Code Cleanup

  • Removed legacy interfaces from filmstrip/interfaces.ts
    • Cleaned up unused type definitions
    • Streamlined the interface structure

Benefits

  • Improved modularity : Surface scroll functionality is now a reusable component
  • Better separation of concerns : Scroll logic is abstracted into its own component
  • Enhanced maintainability : Cleaner component architecture
  • Future-ready : New scroll component can be used by other components

Testing

  • ✅ All existing filmstrip tests pass with the new implementation
  • ✅ New CdrSurfaceScroll component has comprehensive test coverage
  • ✅ No breaking changes to the public API

This refactor maintains backward compatibility while introducing a more flexible and reusable scrolling solution for the Cedar design system.

@c4rlosviteri c4rlosviteri requested review from mhewson and saagude June 30, 2025 16:05
@c4rlosviteri c4rlosviteri merged commit a8a0933 into main Jul 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants