Closed
Conversation
… update tabbable to v6 - Replace ESLint/Prettier with oxlint and oxfmt - Install commitizen with cz-conventional-changelog and prepare-commit-msg hook - Add TypeScript types.ts files for all components from pr/typescript-types - Update tabbable from v4 to v6 (named export API), remove @types/tabbable - Fix CdrPopover to imperatively set aria-controls on trigger child via onMounted - Fix CdrLabelStandalone whitespace in required/optional spans - Add 68 new component entrypoints in src/entrypoints/ - Update and regenerate all affected test snapshots (60+ updated) - Tests: 4 pre-existing failures remain (missing deps), 0 new failures
- Fix test imports: replace @vue/runtime-core with vue in CdrAccordionGroup, CdrInput, and CdrLabelWrapper specs (h is re-exported from vue directly) - Fix CdrBanner spec: replace lodash with lodash-es (installed devDep) - Update snapshots for CdrAccordionGroup (7), CdrBanner (0), CdrInput (22), CdrLabelWrapper (1) — newly unblocked after import fixes - Add 8 missing text preset entrypoints: body, eyebrow, heading-display, heading-sans, heading-serif, subheading-sans, utility-sans, utility-serif - Add CdrFormError, CdrLabelStandalone, CdrLabelWrapper, CdrPopup, CdrFilmstripEngine to lib.ts (were in entrypoints but missing from main export) - Result: 64/64 test files pass, 550/550 tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
...
Checklist:
Design:
Cross-browser testing:
Unit testing:
A11y:
Documentation: