Add 2023-2024 season forecasts#30
Merged
lshandross merged 3 commits intomainfrom Jul 31, 2025
Merged
Conversation
nickreich
requested changes
Jul 29, 2025
Member
nickreich
left a comment
nickreich
left a comment
There was a problem hiding this comment.
The content looks good here. My request is largely cosmetic.
It appears that the ordering of the eval sets is the ordering that they appear in the drop-down menu. And the first eval set listed will be the first/default selection when the evals page loads. I suggest having the ordering be
- 2024/2025 state level
- 2024/2025 US level
- 2023/2024 state level
- 2023/2024 US level
- the last weeks sets
I could see moving the "last weeks" sets to the top when we are in the middle of a season? But I think in general, we should direct people towards the longer-run evaluations.
Member
|
Once the above suggestion is addressed, I'm fine merging it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.