Skip to content

Comments

deps: support symfony 8#198

Open
priyadi wants to merge 1 commit intomainfrom
deps/sf8
Open

deps: support symfony 8#198
priyadi wants to merge 1 commit intomainfrom
deps/sf8

Conversation

@priyadi
Copy link
Member

@priyadi priyadi commented Dec 7, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 7, 2025 12:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Symfony 8 to the rekalogika/file monorepo by updating version constraints across multiple packages and CI configuration.

Key changes:

  • Added || ^8.0 constraint to Symfony dependencies in 5 package composer.json files
  • Updated Symfony dependencies in root composer.json (both require and one require-dev package)
  • Added Symfony 8.* to CI test matrix
  • Reorganized root composer.json structure (moved replace section and reordered fields)

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/file-zip/composer.json Added Symfony 8 support to symfony/http-foundation dependency
packages/file-symfony-bridge/composer.json Added Symfony 8 support to symfony/form, symfony/http-foundation, and symfony/validator dependencies
packages/file-server/composer.json Added Symfony 8 support to symfony/http-foundation dependency
packages/file-filepond/composer.json Added Symfony 8 support to 5 Symfony dependencies (dependency-injection, form, http-foundation, http-kernel, options-resolver)
packages/file-bundle/composer.json Added Symfony 8 support to 7 Symfony dependencies in require and 1 in require-dev
composer.json Added Symfony 8 support to multiple dependencies in require and symfony/routing in require-dev; reorganized JSON structure by moving replace section and reordering homepage/type fields
.github/workflows/php.yml Added Symfony 8.* to the CI test matrix alongside existing 6.* and 7.* versions
Comments suppressed due to low confidence (1)

composer.json:87

  • Several Symfony packages in require-dev are missing the || ^8.0 constraint that was added to other Symfony dependencies. For consistency and complete Symfony 8 support, the following packages should also include || ^8.0:
  • symfony/asset (line 71)
  • symfony/asset-mapper (line 72)
  • symfony/debug-bundle (line 73)
  • symfony/dotenv (line 74)
  • symfony/http-client (line 75)
  • symfony/phpunit-bridge (line 78)
  • symfony/property-info (line 79)
  • symfony/runtime (line 81)
  • symfony/twig-bundle (line 83)
  • symfony/var-exporter (line 85)
  • symfony/web-profiler-bundle (line 86)
  • symfony/yaml (line 87)
        "symfony/asset": "^6.2 || ^7.0",
        "symfony/asset-mapper": "^6.2 || ^7.0",
        "symfony/debug-bundle": "^6.2 || ^7.0",
        "symfony/dotenv": "^6.2 || ^7.0",
        "symfony/http-client": "^6.2 || ^7.0",
        "symfony/maker-bundle": "^1.55",
        "symfony/monolog-bundle": "^3.0",
        "symfony/phpunit-bridge": "^6.3 || ^7.0",
        "symfony/property-info": "^6.2 || ^7.0",
        "symfony/routing": "^6.2 || ^7.0 || ^8.0",
        "symfony/runtime": "^6.2 || ^7.0",
        "symfony/stopwatch": "^7.2",
        "symfony/twig-bundle": "^6.2 || ^7.0",
        "symfony/ux-turbo": "^2.20",
        "symfony/var-exporter": "^6.4 || ^7.0",
        "symfony/web-profiler-bundle": "^6.2 || ^7.0",
        "symfony/yaml": "^6.2 || ^7.0",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"symfony/routing": "^6.2 || ^7.0",
"symfony/routing": "^6.2 || ^7.0 || ^8.0",
"symfony/runtime": "^6.2 || ^7.0",
"symfony/stopwatch": "^7.2",
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symfony/stopwatch constraint starts at ^7.2 (not ^6.2 or ^7.0 like other packages). If this package needs Symfony 8 support like the others, it should be updated to ^7.2 || ^8.0 for consistency.

Suggested change
"symfony/stopwatch": "^7.2",
"symfony/stopwatch": "^7.2 || ^8.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant