Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Symfony 8 to the rekalogika/file monorepo by updating version constraints across multiple packages and CI configuration.
Key changes:
- Added
|| ^8.0constraint to Symfony dependencies in 5 package composer.json files - Updated Symfony dependencies in root composer.json (both
requireand onerequire-devpackage) - Added Symfony 8.* to CI test matrix
- Reorganized root composer.json structure (moved
replacesection and reordered fields)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/file-zip/composer.json | Added Symfony 8 support to symfony/http-foundation dependency |
| packages/file-symfony-bridge/composer.json | Added Symfony 8 support to symfony/form, symfony/http-foundation, and symfony/validator dependencies |
| packages/file-server/composer.json | Added Symfony 8 support to symfony/http-foundation dependency |
| packages/file-filepond/composer.json | Added Symfony 8 support to 5 Symfony dependencies (dependency-injection, form, http-foundation, http-kernel, options-resolver) |
| packages/file-bundle/composer.json | Added Symfony 8 support to 7 Symfony dependencies in require and 1 in require-dev |
| composer.json | Added Symfony 8 support to multiple dependencies in require and symfony/routing in require-dev; reorganized JSON structure by moving replace section and reordering homepage/type fields |
| .github/workflows/php.yml | Added Symfony 8.* to the CI test matrix alongside existing 6.* and 7.* versions |
Comments suppressed due to low confidence (1)
composer.json:87
- Several Symfony packages in
require-devare missing the|| ^8.0constraint that was added to other Symfony dependencies. For consistency and complete Symfony 8 support, the following packages should also include|| ^8.0:
symfony/asset(line 71)symfony/asset-mapper(line 72)symfony/debug-bundle(line 73)symfony/dotenv(line 74)symfony/http-client(line 75)symfony/phpunit-bridge(line 78)symfony/property-info(line 79)symfony/runtime(line 81)symfony/twig-bundle(line 83)symfony/var-exporter(line 85)symfony/web-profiler-bundle(line 86)symfony/yaml(line 87)
"symfony/asset": "^6.2 || ^7.0",
"symfony/asset-mapper": "^6.2 || ^7.0",
"symfony/debug-bundle": "^6.2 || ^7.0",
"symfony/dotenv": "^6.2 || ^7.0",
"symfony/http-client": "^6.2 || ^7.0",
"symfony/maker-bundle": "^1.55",
"symfony/monolog-bundle": "^3.0",
"symfony/phpunit-bridge": "^6.3 || ^7.0",
"symfony/property-info": "^6.2 || ^7.0",
"symfony/routing": "^6.2 || ^7.0 || ^8.0",
"symfony/runtime": "^6.2 || ^7.0",
"symfony/stopwatch": "^7.2",
"symfony/twig-bundle": "^6.2 || ^7.0",
"symfony/ux-turbo": "^2.20",
"symfony/var-exporter": "^6.4 || ^7.0",
"symfony/web-profiler-bundle": "^6.2 || ^7.0",
"symfony/yaml": "^6.2 || ^7.0",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "symfony/routing": "^6.2 || ^7.0", | ||
| "symfony/routing": "^6.2 || ^7.0 || ^8.0", | ||
| "symfony/runtime": "^6.2 || ^7.0", | ||
| "symfony/stopwatch": "^7.2", |
There was a problem hiding this comment.
The symfony/stopwatch constraint starts at ^7.2 (not ^6.2 or ^7.0 like other packages). If this package needs Symfony 8 support like the others, it should be updated to ^7.2 || ^8.0 for consistency.
Suggested change
| "symfony/stopwatch": "^7.2", | |
| "symfony/stopwatch": "^7.2 || ^8.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.