test: satisfy phpstan #284
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds PHPStan annotations to suppress static analysis warnings related to array offset access operations. The changes focus on satisfying PHPStan's type checking requirements without modifying the actual code logic.
- Added
@phpstan-ignore offsetAccess.invalidOffsetannotations to suppress PHPStan warnings - Updated existing doc blocks to include PHPStan suppressions alongside existing Psalm suppressions
- Applied suppressions to array access operations that PHPStan cannot statically verify as safe
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Transformer/Trait/ArrayLikeTransformerTrait.php | Added PHPStan suppression to existing doc block for array offset access |
| src/Transformer/Implementation/TraversableToArrayAccessTransformer.php | Added inline PHPStan suppressions for array assignment and unset operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // @phpstan-ignore offsetAccess.invalidOffset | ||
| $target[$key] = $value; |
There was a problem hiding this comment.
The PHPStan suppression comment should use the standard doc block format /** @phpstan-ignore offsetAccess.invalidOffset */ instead of inline comment style to maintain consistency with the existing suppression in ArrayLikeTransformerTrait.php.
| } else { | ||
| foreach ($target as $key => $value) { | ||
| if (!\in_array($value, $values, true)) { | ||
| // @phpstan-ignore offsetAccess.invalidOffset |
There was a problem hiding this comment.
The PHPStan suppression comment should use the standard doc block format /** @phpstan-ignore offsetAccess.invalidOffset */ instead of inline comment style to maintain consistency with the existing suppression in ArrayLikeTransformerTrait.php.
| // @phpstan-ignore offsetAccess.invalidOffset | |
| /** @phpstan-ignore offsetAccess.invalidOffset */ |
No description provided.