Skip to content

fix(#59): clamp meta.last page to minimum of 1 for empty results #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#59): clamp meta.last page to minimum of 1 for empty results #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iib/web/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def pagination_metadata(pagination_query: Pagination, **kwargs) -> PaginationMet
),
'last': url_for(
str(request.endpoint),
page=pagination_query.pages,
page=max(1, pagination_query.pages),
per_page=pagination_query.per_page,
_external=True,
**kwargs,
Expand Down
9 changes: 9 additions & 0 deletions tests/test_web/test_api_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,15 @@ def test_get_builds(app, auth_env, client, db):
assert rv_json['items'][0]['user'] == 'tbrady@DOMAIN.LOCAL'


def test_get_builds_empty(client, db):
rv_json = client.get('/api/v1/builds').json
assert rv_json['items'] == []
assert rv_json['meta']['total'] == 0
assert rv_json['meta']['pages'] == 0
assert rv_json['meta']['last'] == rv_json['meta']['first']
assert 'page=1' in rv_json['meta']['last']


def test_index_image_filter(
app, client, db, minimal_request_add, minimal_request_rm, minimal_request_fbc_operations
):
Expand Down
Loading