Map skip YumSyncOption to type_skip_list [ROK-1828]#238
Merged
crungehottman merged 1 commit intorelease-engineering:masterfrom Apr 9, 2026
Merged
Map skip YumSyncOption to type_skip_list [ROK-1828]#238crungehottman merged 1 commit intorelease-engineering:masterfrom
crungehottman merged 1 commit intorelease-engineering:masterfrom
Conversation
42b20cf to
c15a307
Compare
The skip option for yum repo sync was passed to the rhsm-pulp API as 'skip', but the rhsm-pulp API expects 'type_skip_list'. To correct the disparity, YumSyncOption's 'skip' attribute has been mapped to 'type_skip_list' via the 'pulp_field' parameter, and the sync method has been updated to respect 'pulp_field' metadata when converting sync options to rhsm-pulp API parameters.
c15a307 to
936c817
Compare
rbikar
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skip option for yum repo sync was passed to the rhsm-pulp API as 'skip', but the rhsm-pulp API expects 'type_skip_list'.
To correct the disparity, YumSyncOption's 'skip' attribute has been mapped to 'type_skip_list' via the 'pulp_field' parameter, and the sync method has been updated to respect 'pulp_field' metadata when converting sync options to rhsm-pulp API parameters.