Add expires message header#61
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1276 1276
=========================================
Hits 1276 1276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The header is time in milliseconds to expire the message.
emilyzheng
force-pushed
the
expire-header
branch
from
6247f98 to
b3fa8f1
Compare
midnightercz
approved these changes
Jan 26, 2026
lslebodn
reviewed
Jan 26, 2026
| "mtype": sig_type.value, | ||
| "source": "metadata", | ||
| "expires": self.timeout * self.retries * 1000, | ||
| } |
There was a problem hiding this comment.
IIUC, you are not anymore interested in the 1st message when you do retry.
So IMHO self.timeout * 1000 should be enough
The class Message has dedicated properties related to expiration
property ttl: float
The time to live of the message measured in seconds. Expired messages may be dropped.
property expiry_time: float
The absolute expiry time of the message in seconds using the Unix time_t [IEEE1003] encoding.
Is the current code really equivalent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header is time in milliseconds to expire the message.