fix: explicitly acknowledge UMB messages in receiver#63
Merged
midnightercz merged 1 commit intoJan 29, 2026
Merged
Conversation
Author
|
This solves the problem of messages being received and processed, but never ACK'd by the client. In that situation, they continue to live in the queue. This uses a lot of resources in the broker (to retain the messages when they are no longer needed, to track what messages have been sent and what messages haven't, etc.) By ACKing each message, it allows the broker to perform the proper record keeping in real-time, and reduces resource usage on the broker. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1277 1279 +2
=========================================
+ Hits 1277 1279 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Messages received from ActiveMQ were not being marked as read because the receiver was closing the connection before auto-accept could transmit the acknowledgment to the broker. Add explicit accept() call after parsing each message to ensure proper acknowledgment. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: David Lanouette <dlanouet@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
midnightercz
force-pushed
the
ack-umb-messages
branch
from
69694cf to
f9f0d63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages received from ActiveMQ were not being marked as read because the receiver was closing the connection before auto-accept could transmit the acknowledgment to the broker. Add explicit accept() call after parsing each message to ensure proper acknowledgment.