Skip to content

Skip RPM repositories freshness check on unrelated PRs #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhartman93 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip RPM repositories freshness check on unrelated PRs #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions hack/verify-data.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,30 @@ set -o nounset
cd "$(git rev-parse --show-toplevel)"

# Verify known_rpm_repositories.yml has been updated with entries from extra_rpm_repositories.yml.
outdated="$(./hack/render-known-rpm-repositories.sh | diff data/known_rpm_repositories.yml - || true)"
if [[ -n "${outdated}" && "${outdated}" != "[]" ]]; then
echo "Out of date items found:"
echo "${outdated}"
echo "❌ Run hack/update-known-rpm-repositories.sh"
exit 1
# Only check freshness against the remote source when RPM repository files are part of the change.
# The scheduled update_rpm_repositories workflow keeps the file in sync automatically.
rpm_files_changed=false
if git diff --name-only "${GITHUB_BASE_REF:-main}...HEAD" -- \
data/known_rpm_repositories.yml \
hack/extra_rpm_repositories.yml \
hack/suppressed_rpm_repositories.yml \
hack/render-known-rpm-repositories.sh \
hack/update-known-rpm-repositories.sh 2>/dev/null | grep -q .; then
rpm_files_changed=true
fi

if [[ "${rpm_files_changed}" == "true" ]]; then
outdated="$(./hack/render-known-rpm-repositories.sh | diff data/known_rpm_repositories.yml - || true)"
if [[ -n "${outdated}" && "${outdated}" != "[]" ]]; then
echo "Out of date items found:"
echo "${outdated}"
echo "❌ Run hack/update-known-rpm-repositories.sh"
exit 1
fi
echo '✅ data/known_rpm_repositories.yml has expected extras'
else
echo '⏭️ Skipping RPM repositories freshness check (no relevant files changed)'
fi
echo '✅ data/known_rpm_repositories.yml has expected extras'

# The konflux tag is what is used in Konflux prod. It is updated weekly. For reference:
# https://github.com/redhat-appstudio/infra-deployments/blob/main/components/enterprise-contract/ecp.yaml
Expand Down
Loading