Feat/jon/connectdatabase #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooke-k
commented
Feb 11, 2023
brooke-k
commented
- Added zmq connectivity
- Added framework for connecting to a database (generic template, not a specific database kind)
- Implemented Docker functionality
- Update Dockerfile to have port exposed for DB connection
- Define class to proxy connection between database and core
- Change configs to remove format conflicts - Replace yapf with black to agree with isort - Remove unneeded requirements export
- Run DatabaseProxy on start
- Add sending of dummy messages to database
- Update pre-commit revisions
brooke-k
requested review from
RatikKapoor,
dhyxy,
AhmadJanjua,
Hamd-Khan and
danielakhal
RatikKapoor
approved these changes
Feb 11, 2023
dhyxy
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.