Implement the new VDR function Drain() - #276
Merged
Merged
Conversation
rellla
force-pushed
the
fix-flush
branch
4 times, most recently
from
July 31, 2026 12:24
f524f8d to
94baf22
Compare
|
What does it fix? |
Owner
Author
Currently nothing, because Flush() is not used. It's a preparation for https://www.vdr-portal.de/forum/thread/137351-radio-aufnahmen-mit-vdr-2-8-1/?postID=1394938#post1394938 It should be a loop, not just an if. And imho it must take the drm and filter queue into account. |
fwolter
approved these changes
Jul 31, 2026
Owner
Author
|
Thanks for review. I'll keep this on hold until VDR uaes this Flush() and i can test it. |
rellla
force-pushed
the
fix-flush
branch
8 times, most recently
from
August 9, 2026 19:08
fcd47b4 to
d65e72e
Compare
rellla
force-pushed
the
fix-flush
branch
5 times, most recently
from
August 15, 2026 19:56
15c993e to
3cc2928
Compare
rellla
force-pushed
the
fix-flush
branch
3 times, most recently
from
August 18, 2026 13:59
925b630 to
de00d62
Compare
- force draining the videoReassemblyBuffer - pop the drm buffer from the queue AFTER setting the new PTS - video buffers are empty, when the drm buffer queue is empty AND when the current drm buffer was displayed long enough in trickspeed mode (though it is displayed one more time due to m_displayOneFrameThenPause
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.