Replace custom ringbuffer in cFilterThread by std function - #43
Merged
Conversation
Owner
|
Nice. That would help us to drop the individual ringbuffers used all over the code. Do you want to add your copyright to the files if that is your own work? Did you test that already? |
Author
|
I don't care whether my name appears in the source files. The code is from me and the documentation comments are from Claude Code. I tested playback, fast forward and skipping with h264. |
rellla
reviewed
Oct 9, 2025
rellla
left a comment
rellla
left a comment
Owner
There was a problem hiding this comment.
nice work.
cVideoRender::m_framesRb and cVideoStream::m_packetRb should also be converted ;)
not sure, if the audio ringbuffer could also be done with that...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a thread-safe FIFO buffer, which is essentially a ring buffer, but simply based on
std::deque. The goal is to re-use it for the other custom made ringbuffers, too. But there needs to be some preparation done at the other places, because there is some weird stuff going on.The queue could potentially also made synchronous to eliminate the millisecond polling sleeps for thread synchronization.