refactor: replace magic string constants with enums#68
Merged
Conversation
Add SyncMode enum (Upsert/Append) to replace bare "upsert"/"append" string comparisons across the codebase (~30 sites). Change TableMapping.state from String to the existing SyncState enum, eliminating stringly-typed state comparisons. Add ChangeType::as_i32() to replace the inline numeric mapping in the DuckDB buffer path. All conversions happen at DB/API boundaries (metadata.rs, api.rs); internal code uses typed enums with matches!() throughout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyncModeenum (Upsert/Append) to replace ~30 bare"upsert"/"append"string comparisons across the codebaseTableMapping.statefromStringto the existingSyncStateenum, eliminating stringly-typed state comparisonsChangeType::as_i32()to replace inline numeric mapping (0/1/2) in the DuckDB buffer pathmetadata.rs,api.rs); internal code uses typed enums withmatches!()throughoutTest plan
make installcheck-- regression + daemon tests)cargo checkon all three workspace crates (core, pg, daemon)cargo fmt --all --checkpasses🤖 Generated with Claude Code