Skip to content

Add remark-directive-mdx plugin entry#1467

Closed
re-xyr wants to merge 1 commit intoremarkjs:mainfrom
re-xyr:patch-1
Closed

Add remark-directive-mdx plugin entry#1467
re-xyr wants to merge 1 commit intoremarkjs:mainfrom
re-xyr:patch-1

Conversation

@re-xyr
Copy link
Copy Markdown

@re-xyr re-xyr commented Dec 5, 2025

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

remark-directive-mdx turns directives parsed by remark-directive into JSX elements used by MDX. This change adds remark-directive-mdx to the plugins list.

@github-actions github-actions Bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 5, 2025
[`remark-directive-mdx`](https://github.com/re-xyr/remark-directive-mdx) turns directives parsed by [`remark-directive`](https://github.com/remarkjs/remark-directive) into JSX elements used by MDX.

Signed-off-by: daylily <i@dayli.ly>
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ed7b185) to head (271abe8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1467   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          138       138           
=========================================
  Hits           138       138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remcohaszing
Copy link
Copy Markdown
Member

We list MDX specific plugins in the MDX plugin list, not in the remark plugin list. IMO we should approve mdx-js/mdx#2664, but reject this PR.

@re-xyr
Copy link
Copy Markdown
Author

re-xyr commented Jan 6, 2026

Since mdx-js/mdx#2664 is merged, I am closing this PR.

@re-xyr re-xyr closed this Jan 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 6, 2026

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤞 phase/open Post is being triaged manually

Development

Successfully merging this pull request may close these issues.

2 participants