Add remark-directive-mdx plugin entry#1467
Closed
re-xyr wants to merge 1 commit intoremarkjs:mainfrom
re-xyr:patch-1
Closed
Add remark-directive-mdx plugin entry#1467re-xyr wants to merge 1 commit intoremarkjs:mainfrom re-xyr:patch-1
re-xyr wants to merge 1 commit intoremarkjs:mainfrom
re-xyr:patch-1
Conversation
[`remark-directive-mdx`](https://github.com/re-xyr/remark-directive-mdx) turns directives parsed by [`remark-directive`](https://github.com/remarkjs/remark-directive) into JSX elements used by MDX. Signed-off-by: daylily <i@dayli.ly>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 138 138
=========================================
Hits 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
We list MDX specific plugins in the MDX plugin list, not in the remark plugin list. IMO we should approve mdx-js/mdx#2664, but reject this PR. |
Author
|
Since mdx-js/mdx#2664 is merged, I am closing this PR. |
|
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
remark-directive-mdxturns directives parsed byremark-directiveinto JSX elements used by MDX. This change addsremark-directive-mdxto the plugins list.