-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Include react-router/dom APIs in typedoc #13509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
3387bc8
to
ef05746
Compare
@@ -1,5 +1,5 @@ | |||
{ | |||
"entryPoints": ["./index.ts"], | |||
"entryPoints": ["./index.ts", "./dom-export.ts"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { HydratedRouter, RouterProvider } from "react-router/dom"; | ||
|
||
// TODO: Confirm if this causes tree-shaking issues and if so, convert to named exports | ||
export type * from "react-router"; | ||
export * from "react-router"; | ||
|
||
export type { RouterProviderProps }; | ||
export type { HydratedRouterProps, RouterProviderProps }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exported so they get included in the typedoc output as a clickable link in the HydratedRouter
page
Closing this out as the outcome isn't quite what we want - Ryan is going to take a look at the typedoc stuff |
Closes #13450
This doesn't work as well as I'd hoped - maybe we should just inline the docs now for
react-router/dom
exports?