Skip to content

Remove dynamic react-router import from RSC code #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

markdalgleish
Copy link
Member

The dynamic import from react-router within react-router/rsc is being used to load the client component that wraps all route-level client components. This works within the context of the playground in this repo, but fails in the context of apps installing the package. Instead, we now statically import from react-router to get the fallback value. I've confirmed that this works in both the playground and as an experimental release.

Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: feb78dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 28626d6 into rsc May 13, 2025
5 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-parcel-rsc-app-usage branch May 13, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant