-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
chore: remove npm-run-all
usage
#13718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
chore: remove npm-run-all
usage
#13718
Conversation
|
Hey, I found that the npm-run-all dependency might be unnecessary:
{
// ...
"scripts": {
- "build": "run-s \"build:*\"",
+ "build": "remix build",
- "build:css": "npm run generate:css -- --minify",
- "build:remix": "remix build",
- "dev": "run-p \"dev:*\"",
+ "dev": "remix dev",
- "dev:css": "npm run generate:css -- --watch",
- "dev:remix": "remix dev",
- "generate:css": "npx tailwindcss -o ./app/tailwind.css",
"start": "remix-serve build"
}
// ...
} Can we safely remove this dependency since it's not being used anywhere? Source (L1921 & L1925):
|
3e7499f
to
487a552
Compare
npm-run-all
npm-run-all
usage
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
487a552
to
cc9c0cf
Compare
This upgrades fromnpm-run-all
tonpm-run-all2
. Primarily because the latter is actively maintained, has security updates and a reduced footprint in the dependency tree.I'm sure people from the wider @e18e ecosystem cleanup (like @43081j) will be very happy to see these kind of changes as wellThis package isn't used by any of the code, so it can be removed