Skip to content

chore(react-router): cleanup test setup #13724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jun 2, 2025

These are all available in Node 20 (which is the minimum we use)

Since we're still using jest and jest-environment-jsdom we unfortunatelly can't fully remove these 😢

Decided to go with @kettanaito / @mswjs' jest-fixed-jsdom though as it's handling more cases than we currently do and it's one less thing we need to worry about ourselves

@MichaelDeBoey MichaelDeBoey added dependencies Pull requests that update a dependency file pkg:react-router labels Jun 2, 2025
Copy link

changeset-bot bot commented Jun 2, 2025

⚠️ No Changeset found

Latest commit: 5c18446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup-tests-setup-react-router branch from a26cc05 to aba1e84 Compare June 2, 2025 12:57
@kettanaito
Copy link
Contributor

Just bear in mind that jest-fixed-jsdom is largely a hack and shouldn't be used as a long-lasting solution.

If you can, please explore migrating your tests to run in the browser (Browser Mode in Vitest, Component testing in Playwright and Cypress). Much simpler setup, much better tests, but you need to pay some attention migrating.

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup-tests-setup-react-router branch from aba1e84 to 5c18446 Compare June 4, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed dependencies Pull requests that update a dependency file pkg:react-router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants