fix(react-router/dom/ssr): add nonce to inline critical css
#14691
Conversation
🦋 Changeset detectedLatest commit: d6ec9ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @AnandShiva, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Updated the changeset. Please let me know if anything more is needed for this fix. |
MichaelDeBoey
changed the title
nonce to inline critical css
|
@MichaelDeBoey i see the PR is in changes requested state. If any pending issues, please let me know, can do the same. thank you. |
|
It looks like some of the new unit tests are failing - could you look into those? |
|
Yes @brophdawg11 . checking the same.
|
…nagement and enhance async test stability with `act` and `waitFor`.
Test fixes: refactor: Export `_resetIsHydrated` for internal state ma…
|
The units tests are fixed now @brophdawg11 . |
3 participants
This PR works on an issue #14666 where the nonce prop passed to the component was not being forwarded to the inline <style> tag generated when criticalCss is provided as a string.