POC: clientLoader.unstable_batch - batch clientLoader with single fetch server call#14884
Draft
brophdawg11 wants to merge 2 commits intodevfrom
Draft
POC: clientLoader.unstable_batch - batch clientLoader with single fetch server call#14884brophdawg11 wants to merge 2 commits intodevfrom
brophdawg11 wants to merge 2 commits intodevfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC for a new
unstable_batchflag onclientLoaderthat allows a route's client loader to participate in the normal single fetch server request, rather than forcing a separate out-of-band server call.With
unstable_batch = true:clientLoaderruns, as part of the normal single fetch request alongside all other loadersclientLoadercallsserverLoader(), it awaits the already-in-flight batched response rather than issuing a new requestKnown limitation:
<Link prefetch><Link prefetch>still excludes routes withhasClientLoaderfrom the prefetch.dataURL on the first prefetch, even whenunstable_batch = truebecause we don't have the route module to know ifunstable_batchis set.plan:
clientLoaderBatchboolean to manifest