fix(router): avoid restarting fetcher revalidations#15129
Open
dogxii wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Prevents GET navigations from aborting/restarting fetcher revalidations that are already in-flight (typically triggered by action submissions), allowing the original revalidation to complete.
Changes:
- Track in-flight fetcher revalidations via
revalidatingFetchersInFlightand thread it throughgetMatchesToLoad - Skip restarting a fetcher load during navigation revalidation when the same fetcher is already revalidating in-flight (unless it was explicitly cancelled)
- Update fetcher test expectations and add a patch changes entry
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-router/lib/router/router.ts | Adds and uses an in-flight revalidation tracking set to avoid restarting fetcher revalidations during GET navigations |
| packages/react-router/tests/router/fetchers-test.ts | Updates test to assert in-flight action revalidation fetchers are not aborted/restarted by navigation |
| packages/react-router/.changes/patch.fetcher-revalidation-navigation.md | Documents the patch-level behavior change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Testing: