-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(dev): update remark-mdx-frontmatter
#10579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix(dev): update remark-mdx-frontmatter
#10579
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- packages/remix-dev/package.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/remix-dev/compiler/plugins/mdx.ts:4
- Verify that 'remark-mdx-frontmatter' now provides a default export. If the package version does not support default exports, this change may lead to runtime errors.
import remarkMdxFrontmatter from "remark-mdx-frontmatter";
@brophdawg11 Hi Matt, could you please take a look at this PR and solve the vulnerability issue? |
Does anyone know why the tests are failing? Looks to be an ESM/CJS issue |
Seems like remix-run does not support ESM... |
To solve the cjs/esm issue, you can use a dynamic import inside the
Just need to do I created a PR with my changes here: #10589 |
b29b42c
to
651f4bb
Compare
651f4bb
to
c002572
Compare
looks like the integration tests are only failing on msedge. Are those tests flaky? Can you re-trigger them and see if they pass? Would love to get this fix in sooner rather than later since it seems that it can't be solved with an override 🙏 |
Fix for GHSA-f7f6-9jq7-3rqj
Closes #10576
CC/ @Evanion