Add remix package #10894

brophdawg11 · 2025-12-15T15:25:03Z

Stacked on #10888

Adds a top level remix package that is auto-generated as an umbrella package over all @remix-run/* packages in the repo.

Auto-generated files are one-liner export * from '@remix-run/...'; files in packages/remix/src/lib
Every sub-package and it's sub-exports becomes a sub-export in remix:
- @remix-run/file-storage -> remix/file-storage
- @remix-run/file-storage/fs -> remix/file-storage/fs
pnpm generate-remix will generate the remix package based on the current state of the repo
A github workflow has been added that can automatically re-build on PRs and pushes to main
The root remix/src/index.ts file is manually authored to control the APIs exported from the top-level remix package
- These exports are currently determined by the APIs needed for the 3 root demos/, but I'm sure we'll want to add more as we start taking a closer look at the entire API surface and building more demos
There is also a root index-client.ts file that exports a subset of the remix API from index.ts that can run in the browser - eliminating anything that imports from node:* under the hood
- This is setup behind a client condition so you can build for the browser with esbuild --conditions=client without running across any node imports that would otherwise fail the build
All 3 root demos/ have been converted to use the top-level package and remove @remix-run/* packages from their dependencies

packages/remix/src/index.ts

packages/remix/src/index-client.ts

packages/remix/package.json

mjackson

This PR looks pretty good. The barrel files (index.ts and index-platform.ts) will still need some work to be complete, but we can continue to add things they are missing over time as we begin to use the remix package in earnest. This is a good start.

mjackson · 2025-12-16T04:59:24Z

packages/remix/src/index-platform.ts

+// All other APIs based on core Javascript/Web Fetch API should be exported
+// from the root remix package in `index.ts`
+
+export { asyncContext, getContext } from './lib/async-context-middleware'


Just a note on import/export paths from files (not packages): we always use the file extension to avoid ambiguity. So this should be:

Suggested change

export { asyncContext, getContext } from './lib/async-context-middleware'

export { asyncContext, getContext } from './lib/async-context-middleware.ts'

Maybe we want to add an eslint rule that catches this?

oh interesting - I thought that would already fail at build time and didn't even notice the LLM left them out. I'll look into a way to catch this automatically 👍

Added a lint rule in 625b639

mjackson · 2025-12-16T05:01:12Z

packages/remix/src/index.ts

+  get,
+  post,
+  put,
+  resources,


We should have resource here as well, along with head, options, and patch. I'm thinking we should also have the longform names, createGetRoute, etc.

mjackson · 2025-12-16T05:12:40Z

demos/bookstore/app/utils/context.ts

-import { createStorageKey } from '@remix-run/fetch-router'
-import { getContext } from '@remix-run/async-context-middleware'
+import { createStorageKey } from 'remix'
+import { getContext } from 'remix/platform'


Something feels off to me about this. I have to know that getContext relies on node:async_hooks internally so that I know to get it from remix/platform. Maybe it's better to just import directly from remix/async-context-middleware and ditch the whole idea of remix/platform entirely.

yeah - I think thats a good call. The sub-export is just an added layer of indirection when it's still a single dependency.

mjackson · 2025-12-16T05:13:09Z

demos/bookstore/app/middleware/auth.ts

-import type { Middleware, Route } from '@remix-run/fetch-router'
-import { createRedirectResponse as redirect } from '@remix-run/response/redirect'
+import type { Middleware, Route } from 'remix'
+import { createRedirectResponse as redirect } from 'remix'


This one is so common we'll probably want to have a redirect shorthand that people can import instead of renaming it every time.

Do you think we should do the same for createHtmlResponse and createFileResponse? html would conflict at a global level with the html string helper so if we chose to export from the top-level we'd have to choose one, but they'd both be fine as exports from their individual sub-exports.

I'm not sure about the html helper. I want to see how it feels once we start using components more heavily in the demos and relying less on the html-template library. I just know for now that I want to be able to import redirect directly, or I'm always going to do this rename.

This reverts commit 25e6506.

This reverts commit 1d94b69.

mjackson

Overall I'm starting to think we don't want as much stuff in the main remix export as we originally thought. I realize it feels subjective at this point, but we knew this would be a somewhat subjective exercise going into it.

mjackson · 2025-12-17T16:48:06Z

demos/bookstore/app/middleware/auth.ts

-import type { Middleware, Route } from '@remix-run/fetch-router'
-import { createRedirectResponse as redirect } from '@remix-run/response/redirect'
+import type { Middleware, Route } from 'remix'
+import { createRedirectResponse as redirect } from 'remix'


I'm not sure about the html helper. I want to see how it feels once we start using components more heavily in the demos and relying less on the html-template library. I just know for now that I want to be able to import redirect directly, or I'm always going to do this rename.

demos/bookstore/app/router.ts

demos/unpkg/app/directory.ts

packages/remix/src/index.ts

MichaelDeBoey linked an issue Dec 15, 2025 that may be closed by this pull request

Add remix package #10786

Open

brophdawg11 commented Dec 15, 2025

View reviewed changes

packages/remix/src/index.ts Outdated Show resolved Hide resolved

brophdawg11 commented Dec 15, 2025

View reviewed changes

packages/remix/src/index-client.ts Outdated Show resolved Hide resolved

brophdawg11 commented Dec 15, 2025

View reviewed changes

packages/remix/package.json Outdated Show resolved Hide resolved

mjackson reviewed Dec 16, 2025

View reviewed changes

brophdawg11 force-pushed the brophdawg11/docs-eslint branch from 12b0f08 to 9b91b90 Compare December 16, 2025 17:31

Base automatically changed from brophdawg11/docs-eslint to main December 16, 2025 17:33

brophdawg11 added 6 commits December 16, 2025 12:33

Auto-generate the Remix package

d288902

Update bookstore demo to use remix package

4e095c9

Convert sse demo to use remix package

3bc1f2e

Convert unpkg demo to use remix package

9c29640

Add remix client export condition

bc5714e

Move from a client condition to a platform sub-export

f0f2f14

brophdawg11 force-pushed the brophdawg11/remix-package branch from 8c79a0f to f0f2f14 Compare December 16, 2025 17:34

brophdawg11 marked this pull request as ready for review December 16, 2025 17:34

brophdawg11 added 4 commits December 16, 2025 13:39

Add eslint-plugin-import

625b639

Remove remix/platform export

4a74dfe

Add more exports to remix

1210a54

Add .changes dir, ignore demos assets directories in eslint

d77c526

brophdawg11 mentioned this pull request Dec 16, 2025

Dedup workflow runs on PRs #10902

Merged

brophdawg11 and others added 9 commits December 16, 2025 14:29

Update CI job to build remix

6617af9

Remove 2 files to test CI generation and push

035f6f0

build: update remix package

dc98537

Add delay before pushing to test CI run

1d94b69

Remove 2 files to test CI generation and push

ee2c97a

build: update remix package

5b952a5

Remove paths filter?

25e6506

Remove 2 files to test CI generation and push

9027358

build: update remix package

e31ff6e

brophdawg11 added 4 commits December 16, 2025 14:54

Revert "Remove paths filter?"

439a4fd

This reverts commit 25e6506.

Revert "Add delay before pushing to test CI run"

a9aa7f3

This reverts commit 1d94b69.

Disable generate-remix workflow on PRs

6c77f9f

Merge branch 'main' into brophdawg11/remix-package

5771019

mjackson requested changes Dec 17, 2025

View reviewed changes

brophdawg11 added 11 commits December 17, 2025 12:16

Trim remix exports

e5c85c3

Update script to generate and lift change files

984234b

Remove source file if export is removed

694c3bc

Updates

2ae9a86

Put all change file generation behind the flag

4b88ff2

Add lib path to publishConfig.exports

6fac18d

Add script to tag remix nightly releases

bb7ac5d

Merge branch 'main' into brophdawg11/remix-package

2f437b4

Update with component package

b891ba1

Update lockfile for component package

03f0d07

Merge branch 'main' into brophdawg11/remix-package

324b024

	export { asyncContext, getContext } from './lib/async-context-middleware'
	export { asyncContext, getContext } from './lib/async-context-middleware.ts'

Add remix package #10894

Are you sure you want to change the base?

Add remix package #10894

Conversation

brophdawg11 commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mjackson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjackson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

brophdawg11 commented Dec 15, 2025 •

edited

Loading