Remove SuperHeaders class, add new parsing utils
#10911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MichaelDeBoey
left a comment
MichaelDeBoey
left a comment
There was a problem hiding this comment.
@markdalgleish If this PR is created to fix #10872, an alternative could be to go with @alexandredev3's solution from #10889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
SuperHeadersclass from@remix-run/headersin favour of individual header parsing functions and updates all consumers to use the new utils.@remix-run/headersno longer exportsSuperHeaders/Headersclass. Instead, it now exports individualparse*()functions for each header type (e.g.parseContentType(),parseAccept(), etc.) along withparseRawHeaders()andstringifyRawHeaders()utilities.@remix-run/fetch-routernow returns a plainHeadersinstance fromRequestContext.headersinstead ofSuperHeaders, and has dropped the@remix-run/headerspeer dependency.@remix-run/multipart-parserhas been updated to use the new header parsing functions.@remix-run/responsehas been updated to use the new header parsing functions.