-
Notifications
You must be signed in to change notification settings - Fork 2.6k
docs(other-api/adapter) Improve Cloudflare Workers examples #6084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR updates the Cloudflare Workers API examples to include `mode` in the `createRequestHandler`. This is needed with the unstable dev server (and harmless without it).
|
Hi @xanderberkein, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Should we add this to all of the examples on this page? cc @pcattori |
@brophdawg11 The cloudflare adapters are actually the only adapters where However, the Cloudflare Workers adapter examples here are a bit outdated now. Since |
This PR updates the Cloudflare Workers API examples to include
mode
in thecreateRequestHandler
. This is needed with the unstable dev server (and harmless without it).