docs(other-api/adapter) Improve Cloudflare Workers examples#6084
docs(other-api/adapter) Improve Cloudflare Workers examples#6084xanderberkein wants to merge 2 commits intoremix-run:mainfrom
Conversation
This PR updates the Cloudflare Workers API examples to include `mode` in the `createRequestHandler`. This is needed with the unstable dev server (and harmless without it).
|
|
Hi @xanderberkein, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Should we add this to all of the examples on this page? cc @pcattori |
|
@brophdawg11 The cloudflare adapters are actually the only adapters where However, the Cloudflare Workers adapter examples here are a bit outdated now. Since |
|
Thank you for opening this pull request, and our apologies we haven't gotten around to it yet! With the release of React Router v7 we are sun-setting continued development/maintenance on Remix v2. If you have not already upgraded to React Router v7, we recommend you do so. We've tried to make the upgrade process as smooth as possible with our Future Flags. We are now in the process of cleaning up outdated issues and pull requests to improve the overall hygiene of our repositories. We plan to continue to address 2 types of issues in Remix v2:
If you believe this pull request meets one of those criteria, please respond or create a new pull request so it pops up on our radar (since github notifications may get lost in the noise 😕). For all other issues/changes, ongoing maintenance will be happening in React Router v7, so:
If you have any questions you can always reach out on Discord. Thanks again for providing feedback and helping us make our framework even better! |
This PR updates the Cloudflare Workers API examples to include
modein thecreateRequestHandler. This is needed with the unstable dev server (and harmless without it).