Depend on individual JLine3 modules, not the bundle - #2419
Merged
Conversation
* Removed dependency artifacts `org.jline:jline` * Added dependency artifacts `org.jline:jline-reader` and `org.jline:jline-console` (`jline-builtins`, `jline-native`, `jline-terminal` and `jline-style` are added transitively) * Removed `org.jline` module dependency in module-info. * Added `org.jline.reader` and `org.jline.console` module dependneices to module-info * Updated README.md with JPMS info.
remkop
reviewed
May 16, 2025
remkop
left a comment
remkop
left a comment
Owner
There was a problem hiding this comment.
@brett-smith Looks good, thank you!
I may include this in the next bugfix release 4.7.7 rather than waiting for 4.8. Any objections/comments?
Also, did you have a chance to build this and verify that it actually works as intended?
remkop
added
theme: shell
Contributor
Author
|
Sure, sooner rather than later helps me out too :) And yes, I tested this by publishing to my local repository, and using it in a fully modular application with separate jline modules, and the jline progress bar extension too. |
remkop
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2418.
org.jline:jlineorg.jline:jline-readerandorg.jline:jline-console(jline-builtins,jline-native,jline-terminalandjline-styleare added transitively)org.jlinemodule dependency in module-info.org.jline.readerandorg.jline.consolemodule dependencies to module-info