Skip to content

Fix #2501 by including function in option auto complete function name #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remkop merged 6 commits into from
May 6, 2026
+11 −5
Merged

Fix #2501 by including function in option auto complete function name #2502

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8bc9966
drop down hyphen to underscore in autocomplete bash script
btw04 Jan 12, 2026
be5a83b
check and remove duplicate function sub hierarchy aliases
btwCQSE Jan 14, 2026
42958e8
refactor for java 5
btwCQSE Jan 19, 2026
eb97b0b
include function name in option auto completion function name
btwCQSE Jan 19, 2026
d441771
Merge branch 'main' into fix_completion_function_name
remkop May 6, 2026
f5f4f0b
Merge branch 'main' into fix_completion_function_name
remkop May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/main/java/picocli/AutoComplete.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,11 +777,17 @@ private static void generatePositionParamCompletionCandidates(StringBuilder buff
}

private static void generateCompletionCandidates(StringBuilder buff, OptionSpec f) {
buff.append(format(" local %s_option_args=(\"%s\") # %s values\n",
bashify(f.paramLabel()),
concat("\" \"", extract(f.completionCandidates())).trim(),
f.longestName()));
buff.append(generateCompletionCandidates(f));
}

private static String generateCompletionCandidates(OptionSpec f) {
return format(" local %s_%s_option_args=(\"%s\") # %s values\n",
bashify(f.longestName()).replaceFirst("^_+", ""),
bashify(f.paramLabel()),
concat("\" \"", extract(f.completionCandidates())).trim(),
f.longestName());
}

private static List<String> extract(Iterable<String> generator) {
List<String> result = new ArrayList<String>();
for (String e : generator) {
Expand Down Expand Up @@ -848,7 +854,7 @@ private static String generateOptionsCases(List<OptionSpec> argOptionFields, Str
if (option.completionCandidates() != null) {
buff.append(format("%s %s)\n", indent, concat("|", option.names(), null, new SingleQuoteFunction()))); // " -u|--timeUnit)\n"
buff.append(format("%s local IFS=$'\\n'\n", indent));
buff.append(format("%s COMPREPLY=( $( compReplyArray \"${%s_option_args[@]}\" ) )\n", indent, bashify(option.paramLabel())));
buff.append(format("%s COMPREPLY=( $( compReplyArray \"${%s_option_args[@]}\" ) )\n", indent, generateCompletionCandidates(option)));
buff.append(format("%s return $?\n", indent));
buff.append(format("%s ;;\n", indent));
} else if (type.equals(File.class) || "java.nio.file.Path".equals(type.getName())) {
Expand Down
Loading