Fix #2407 when @ArgGroup is reused - #2508
Merged
Merged
Conversation
alexanderankin
approved these changes
Mar 8, 2026
remkop
self-requested a review
May 5, 2026 08:31
remkop
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change preserves all instances of the same @Arggroup across all commands it is applied to.
fixes #2407
It looks like when an ArgGroup is reused, it is overwritten in argGroupElementsByType when being parsed (but not in argGroupElementsByVar which has actual unique keys). This means when iterating through argGroupElementsByVar later in the process, it hits ArgGroupBuilders that were not fully populated in connectModel() (which iterates over argGroupElementsByType), leading to a failure to fully realize the ArgGroupSpec in its constructor (when args.isEmpty() and subgroups.isEmpty()).