cli: add blank after nocheck directive to indicate whole file #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's not a blank line between the topmost import and the `@ts-nocheck` directive, import sorting tools in formatters like biome.js may not be able to discern whether the directive is for the file or just the first import. For example, in _batcher.js_, we have these imports ```ts // @ts-nocheck import type { GraphqlOperation } from './generateGraphqlOperation'; import { GenqlError } from './error'; ``` When biomejs sorts this, it's not clear that the directive is for the file, so we end up with this (which has type errors): ```ts import { GenqlError } from './error'; // @ts-nocheck import type { GraphqlOperation } from './generateGraphqlOperation'; ```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No urgency to this, but I noticed the issue and figured I'd submit a fix. I'm happy to make any necessary adjustments as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's not a blank line between the topmost import and the
@ts-nocheckdirective, import sorting tools in formatters like biome.js may not be able to discern whether the directive is for the file or just the first import.For example, in batcher.ts we have these imports:
When biomejs sorts this, it's not clear that the directive is for the file, so we end up with this (which has type errors):
This change will add an extra blank line, so the result is this (directive position will be preserved):