Fix emoji crash #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These dependencies are required for the build to work but were previously missing - likely because they came from the global pnpm install.
This update fixes crashes when encountering utf8/emoji characters. 8e29e2d is also the last commit before a breaking change was introduced to lol-html which makes the rust/wasm bindings in src/element.rs incompatible — fixing this will require more work, so I'm avoiding that for now.
IgorMinar
added a commit
to IgorMinar/htmlrewriter-crash-repro
that referenced
this pull request
Feb 9, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of lol-html is quite out of date and causes crashes when processing emoji/utf8 chars, see: https://github.com/igorminar/htmlrewriter-crash-repro
This PR updates the version of lol-html to the last compatible version before breaking changes were introduced to lol-html. Fortunately this version is good enough to fix the emoji/utf8 issues.