-
Notifications
You must be signed in to change notification settings - Fork 0
Android #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android #1002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the application version to 3.41.0 and implements Android-specific UI changes alongside backend improvements. The main focus is hiding billing-related features on Android, upgrading the Android Gradle plugin, removing the beta label from scripting features, and simplifying log retention logic.
Key changes:
- Hide billing and subscription features on Android using
<MobileUI android hide>wrapper - Upgrade Android Gradle plugin from 8.12.1 to 8.13.0
- Simplify log retention evaluation logic by removing complex helper functions
- Remove beta label from scripting feature in sidebar
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump to 3.41.0 |
| ios/App/App.xcodeproj/project.pbxproj | iOS version and build number updates |
| frontend/src/routers/Router.tsx | Remove Android redirection wrapper from account route |
| frontend/src/pages/AccountPage.tsx | Hide subscription and billing menu items on Android |
| frontend/src/models/logs.ts | Simplify log retention calculation logic |
| frontend/src/components/SidebarNav.tsx | Remove beta label from scripting navigation item |
| frontend/src/components/EventList/EventList.tsx | Hide upgrade button on Android and remove browser check |
| frontend/src/components/AvatarMenu.tsx | Remove Android-specific launch icon from account menu |
| frontend/package.json | Version bump to 3.41.0 |
| electron/package.json | Version bump to 3.41.0 |
| android/build.gradle | Upgrade Gradle plugin to 8.13.0 |
| android/app/build.gradle | Android version updates |
Files not reviewed (1)
- electron/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Changes