-
Notifications
You must be signed in to change notification settings - Fork 0
Android #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android #1003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the application version from 3.41.0 to 3.42.0 across multiple platforms and hides upgrade-related UI elements on Android devices by wrapping them with the MobileUI component. The change updates the Android build workflow to deploy directly to completed status instead of gradual rollout.
- Version bump to 3.42.0 across package.json files and platform-specific configurations
- Wrapping upgrade buttons and links with
MobileUI android hideto prevent display on Android - Changed Android deployment from gradual rollout (inProgress with 20% userFraction) to full release (completed status)
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump to 3.42.0 |
| frontend/package.json | Version bump to 3.42.0 |
| electron/package.json | Version bump to 3.42.0 |
| android/app/build.gradle | Version bump to 3.42.0 and build number increment |
| ios/App/App.xcodeproj/project.pbxproj | Version and build number updates for iOS |
| frontend/src/components/MobileUI.tsx | Logic change from AND to OR for platform detection |
| frontend/src/pages/OrganizationRolesPage.tsx | Hide upgrade button on Android |
| frontend/src/pages/OrganizationAddPage.tsx | Hide upgrade chip on Android |
| frontend/src/pages/CustomerPage.tsx | Hide update plan button on Android |
| frontend/src/components/UpgradeNotice.tsx | Hide upgrade button on Android |
| frontend/src/components/UpgradeBanner.tsx | Hide upgrade chip on Android |
| frontend/src/components/PlanActionChip.tsx | Hide plan action chip on Android |
| frontend/src/components/LicensingServiceNotice.tsx | Hide upgrade button and learn more link on Android |
| frontend/src/components/LicensingNoticeDisplay.tsx | Hide upgrade buttons and learn more links on Android |
| .github/workflows/build-android.yml | Change deployment to completed status and remove gradual rollout |
Files not reviewed (1)
- electron/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 17 out of 19 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- electron/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Changes