Reworks S3 streaming store to be much faster and much more reliable #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey can't be authenticated Also tweaks rate limit parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining folder descriptions itself, uses S3 list and HEAD commands to calculate folder descriptions, which are then cached as S3 blobs. Content-Type, which S3 inexplicably doesn't natively return in list commands, is cached as 0-length blobs next to their content blobs. Once the Content-Type blobs are written, complete folder descriptions can be generated from S3 list commands. When a document is updated, all its ancestor folder description caches are deleted. Thus, restoring or updating many documents is efficient.
This also facilitates integrations with non-RS software — after updating S3 blobs (documents), it just needs to delete the ancestor folder description caches.
Separately, when server is overloaded, Retry-After headers for 503 and 429 are proportional to the overload, giving negative feedback which keeps the server operating at maximum throughput.