Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Hub Image #37
base: master
Are you sure you want to change the base?
Docker Hub Image #37
Changes from all commits
5bec28c
61c8f37
ace0a83
e7e6c44
304ca08
2b7fffd
72319ae
0ed6413
094109b
d924d26
55ccc56
a53db93
6520106
cefdcb4
9d63a99
abb70bd
ef0266c
ff66f68
d848bf1
e6b5d89
2d1207b
98a9f55
19bfd49
6b06312
098ddaf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is doubled (see line 5).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One for each container (build and the main container), thought it isn't used in the build container, so can delete it... done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it OK to always bring in latest version? Should this be explicitly controlled? I guess same for
alpine:latest
on line 1.I'm cool with it as it is, just thinking out loud, in light of recent debacles.
Was also looking for "dynamic" bits between October and now that could cause my failures building. But I don't think this is it either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the default tag there points to, but latest active LTS makes most sense to me for node.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an issue with this PR, but wondering out loud, what is the gate at which we consider Armadietto production ready? I think hard to assess how many production workloads are already running on top of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! I think it merits its own issue or forums topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under MacOS 11.6.2, with Docker Desktop 4.4.2, this line alone evokes the error
Unable to find image 'remotestorage/armadietto:latest' locally
Should there be a build step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Will work once it has been published, but yes, will add info about building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in a53db93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have just added info about running the docker image behind a proxy as well as it is quite a common thing to do
723f8436520106