Skip to content

Added a "Quick Start" to readme#13

Open
JakubNer wants to merge 6 commits intoremotestorage:masterfrom
JakubNer:master
Open

Added a "Quick Start" to readme#13
JakubNer wants to merge 6 commits intoremotestorage:masterfrom
JakubNer:master

Conversation

@JakubNer
Copy link
Copy Markdown

@JakubNer JakubNer commented Apr 9, 2019

Just added "Quick Start" to readme.

Thing is, for this PR to make sense, the remotestorage/myfavoritedrinks repo needs its settings changed so that github pages are enabled.

@JakubNer
Copy link
Copy Markdown
Author

JakubNer commented Apr 9, 2019

Just realized reading draft-dejong that there is a version of this app running at https://drinks-unhosted.5apps.com/.

I don't think it's this particular version--different drink on splash and different widget (at least visually).

I think it's still worthwhile to have the GitHub pages enabled on this repo and have this version hosted from this repo.

@raucao
Copy link
Copy Markdown
Member

raucao commented Apr 10, 2019

This is the official example app, hosted at https://myfavoritedrinks.remotestorage.io/ as well. You've seen that one?

@JakubNer
Copy link
Copy Markdown
Author

This is the official example app, hosted at https://myfavoritedrinks.remotestorage.io/ as well. You've seen that one?

Ah perferct, no I haven't. That's perfect, so this repo is already hosted somewhere. Yea I think the README just needs to say that then :).

I'll change this PR to point at https://myfavoritedrinks.remotestorage.io/ so no need for GitHub pages 👍.

@raucao
Copy link
Copy Markdown
Member

raucao commented Apr 10, 2019

That's perfect, so this repo is already hosted somewhere.

Yup, and updating it is part of the rs.js release checklist, so that it always comes with the latest version of the library: https://remotestoragejs.readthedocs.io/en/latest/contributing/release-checklist.html

[1] change to be more generic for other servers than armadietto
[2] add reference to https://myfavoritedrinks.remotestorage.io/
Copy link
Copy Markdown
Member

@raucao raucao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait! I had a look just now, and added a comment.

README.md Outdated
* *tester* being a test username
* *localhost:8000* is where the *remotestorage* server is responding as per step 2.

[5] what happens at this point is server specific, OAuth flow should redirect you to onboarding and login
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the username and port number, i.e. user address, above is also server-specific, and usually you will have to create a user account first. Maybe it would make sense to declare this entire howto being specific to Armadietto?

README.md Outdated
[1] Visit https://myfavoritedrinks.remotestorage.io/

* it's this app hosted
* the app needs to be hosted using a Web server--don't just run [index.html](index.html) from file system
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the app needs to be hosted using a Web server--don't just run [index.html](index.html) from file system
* the app needs to be hosted using a Web server--don't just open [index.html](index.html) from file system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants